Comment 8 for bug 377054

Revision history for this message
Kees Cook (kees) wrote :

Hi! Thanks very much for the debdiffs. There are a few suggestions I'd like to make:
 - the versioning is almost perfect, but needs to be higher than the existing versions. Instead of 1.6.19-1.1ubuntu0.9.04.1, you'd want 1.6.19-1.1ubuntu1.9.04.1 since 1.6.19-1.1ubuntu1 is already in the archive and higher than 1.6.19-1.1ubuntu0.9.04.1. The distro-numbering is right on, though. :)
 - we tend to prefer that patches carry Description, Ubuntu, Upstream, and sometimes Patch tags, as detailed here: https://wiki.ubuntu.com/UbuntuDevelopment/PatchTaggingGuidelines

I'm updating the packaging and patches and will upload this shortly. Thanks again!