Comment 10 for bug 1990856

Revision history for this message
Dan Bungert (dbungert) wrote :

Hi Dan W, thanks for the patches.

I have uploaded these.

A few thoughts that weren't blocking the upload:
* it feels strange to upload these when the debootstrap tests have been broken for as long as I cared to look for, but these patches doesn't make that situation worse.
* I don't love the "sleep 2" in the test, but it seems to be working fine on devel so I'll move on. I would suggest though, if you feel like iterating, changing that to either poll the flask app for startup with a timeout, or just make the sleep longer, and make it loudly complain about the fact that the timeout was hit.
* since you've started these patches, the sponsors process has been restarted and the sponsor queue is now empty, that should be a good mechanism to get someone to take a look at future proposals. https://discourse.ubuntu.com/t/ubuntu-patch-pilots/37705 has details