Comment 21 for bug 1033727

Revision history for this message
Peter Schaefer (derschaefer) wrote : Re: [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

Hi,

well - it's probably only for historic interest, but if i made no bisecting mistake, this commit has fixed it (note that
the meaning of 'good' and 'bad' is swapped due to how git bisect works):

root@debian:~/qemu_git/qemu-kvm# git bisect good
Bisecting: 87 revisions left to test after this (roughly 7 steps)
[c26032b2c91721245bfec542d94f37a0238e986e] target-xtensa: don't emit extra tcg_gen_goto_tb
root@debian:~/qemu_git/qemu-kvm# git bisect good
Bisecting: 43 revisions left to test after this (roughly 6 steps)
[1fd959466574c3d46f4898f2e27cd3b1060338e4] tcg-sparc: Mask shift immediates to avoid illegal insns.
root@debian:~/qemu_git/qemu-kvm# git bisect bad
Bisecting: 24 revisions left to test after this (roughly 5 steps)
[e55f523d7977480462151d8abb0ebb4b1747eabf] tcg-hppa: Fix broken load/store helpers
root@debian:~/qemu_git/qemu-kvm# git bisect good
Bisecting: 12 revisions left to test after this (roughly 4 steps)
[09054d19e72f6991cd359d41c479badd92f62a06] usb-redir: Add chardev open / close debug logging
root@debian:~/qemu_git/qemu-kvm# git bisect good
Bisecting: 6 revisions left to test after this (roughly 3 steps)
[a221ae3fcc55fcc3911587bc572af88eed3342dd] tcg-sparc: Fix ADDX opcode.
root@debian:~/qemu_git/qemu-kvm# git bisect bad
Bisecting: 2 revisions left to test after this (roughly 2 steps)
[cfb75cb9807463ebe18b127096b48b5d0db1ce03] Merge branch 'usb.65' of git://git.kraxel.org/qemu
root@debian:~/qemu_git/qemu-kvm# git bisect bad
Bisecting: 0 revisions left to test after this (roughly 1 step)
[72a04d0c178f01908d74539230d9de64ffc6da19] uhci: Don't queue up packets after one with the SPD flag set
root@debian:~/qemu_git/qemu-kvm# git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[35efba2cc6812dc980c336d7b9bf81dbfb5daf00] usb-redir: Revert usb-redir part of commit 93bfef4c
root@debian:~/qemu_git/qemu-kvm# git bisect good
72a04d0c178f01908d74539230d9de64ffc6da19 is the first bad commit
commit 72a04d0c178f01908d74539230d9de64ffc6da19
Author: Hans de Goede <email address hidden>
Date: Wed Sep 12 15:08:40 2012 +0200

     uhci: Don't queue up packets after one with the SPD flag set

     Don't queue up packets after a packet with the SPD (short packet detect)
     flag set. Since we won't know if the packet will actually be short until it
     has completed, and if it is short we should stop the queue.

     This fixes a miniature photoframe emulating a USB cdrom with the windows
     software for it not working.

     Signed-off-by: Hans de Goede <email address hidden>
     Signed-off-by: Gerd Hoffmann <email address hidden>

:040000 040000 18e7490171762dec04cb8ce49fd21e0b685b53b2 86f7cb33d8b77828e671c5fb39c9d137d39eca06 M hw
root@debian:~/qemu_git/qemu-kvm#

HTH.

Regards,
  Peter