loggerhead

  1. Bug #306631
  2. Comment #2

Comment 2 for bug 306631

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

That looks pretty good!

Some comments;

1) Why do you have a class (PygmentsHighlighter) with a single staticmethod? This is Python, not Java, a free function would be fine :)

2) Would you be prepared/able to assign the copyright to Canonical for this? Loggerhead's copyright situation is a bit murky, but we are trying to make it clearer, gradually...

3) I wouldn't worry about themes at all for now. Just make it look OK with the default loggerhead look (which I think it does OK already in fact).

I can tweak the code a bit, so I guess it's only really 2) I need an answer to.