Comment 4 for bug 297458

Revision history for this message
William Grant (wgrant) wrote :

I have this mostly done, but there are two complications, and I'm unsure how to solve either.

 - Several IBug methods and IBugNomination.target need an interface like ISeriesBugTarget (with IProductSeries and IDistroSeries inheriting from it). I could define it as an empty interface, but that would leave IBugNomination.target without any attributes in launchpadlib for the moment. For arguments that approach is fine, though.
 - IBug.addNomination automatically approves the nomination if possible. This is a problem if you technically have permission, but should not exercise it (bug #253597). Since the UI behaviour will hopefully change to require explicit approval later, I think it should be explicit in the API from the start. Should I remove the automatic approval from IBug.addNomination, and make the view code call IBugNomination.approve?