Comment 11 for bug 82159

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Just a couple of questions, and +1!

[1]

+ # Specify a low timeout because it may be quite normal for this
+ # service to not be provided, if the client is being run in non-root
+ # mode.

2 seconds seems to be a bit on the low side. Would increasing it a bit hurt too much on the normal failure case, or perhaps can we catch the error and see if the other side isn't up at all to make a more conscious decision?

[2]

+ if (config.bus == "system"
+ and not (os.getuid() == 0 or pwd.getpwnam("landscape").pw_uid == os.getuid())):

That reminds me, can landscape use the system bus according to the dbus configuration we have?

Btw, that line is now running over 80 cols.