Cool, I've addressed this with Chris' review below.
[Free]
Thanks!
[Chris]
[1]
No problem. :-)
[2]
My goal was to have a way to both prevent it from being left unset to something sensible by mistake (IOW, I didn't want to have fetch() as a default), and to prevent having to pass the parameters explicitly at all times. In any case, it's bogus that it had no tests (it would break anyway, but might break with a weird NameError or something), and the concept was also awkward no matter what. I'm now enforcing the parameter to be passed in.
[3]
Done, I've added that to both places. This should also sort Kevin's comment.
[Kevin]
[1]
Cool, I've addressed this with Chris' review below.
[Free]
Thanks!
[Chris]
[1]
No problem. :-)
[2]
My goal was to have a way to both prevent it from being left unset to something sensible by mistake (IOW, I didn't want to have fetch() as a default), and to prevent having to pass the parameters explicitly at all times. In any case, it's bogus that it had no tests (it would break anyway, but might break with a weird NameError or something), and the concept was also awkward no matter what. I'm now enforcing the parameter to be passed in.
[3]
Done, I've added that to both places. This should also sort Kevin's comment.
[4]
Oops.. changed. :-)
[5]
Good point! That's fixed!
[6]
Test added!
Thanks for the great review!