Comment 14 for bug 427773

Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 427773] Re: empty limbo dirs prevents to successful execution of bzr commands and left working tree locked

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Because limbo and pending-deletion directories are both EMPTY -- I don't
> think bzr should blow up as it doing today. It can delete or reuse them.
> Today the check is VERY VERY hard: presence of any of this dirs even if
> they're empty -- and you get the problem.
>
> Why?

Because the directories shouldn't be there at all. If you kill shelve
after you've shelved some changes, then the directories will be present
and have contents. Being present and empty is just a special case of
them being present.

Special handling makes bzr's behaviour less predictable, and I don't
think it should be done for rare failure modes.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrKSHAACgkQ0F+nu1YWqI0vAQCfZJD3oVDmlu7XF2hjrnLwNk/8
3loAn1XiQQ4R+JoAVfftoMPvjoZC7Ang
=U9p6
-----END PGP SIGNATURE-----