Checkbox

media card storage tests only look at sdio devices

Bug #979356 reported by Daniel Manrique on 2012-04-11

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Checkbox	Fix Released	High	Daniel Manrique	Checkbox 0.13.7 "precise_fixes_5"

Bug Description

The fix for bug 953160 in rev 1322 of checkbox updated job definitions so that the insertion and removal tests look at the sdio, usb and scsi buses for card insertions (as some systems present cards as those kinds of devices).

Unfortunately this change was not done for the actual storage transfer tests (the ones using removable_storage_test). Thus these tests always fail, and they prevent the depending removal test from running.

This can be ascertained in jobs/mediacards.txt.in, for instance:

plugin: manual
name: mediacard/mmc-insert
command: removable_storage_watcher insert sdio usb scsi

the matching storage test:

plugin: shell
name: mediacard/mmc-storage
depends: mediacard/mmc-insert
command: removable_storage_test sdio

notice the second one only looks at sdio, while it should probably consider usb and scsi as well.

Adding them to the test is the "easy" way to fix this. Not perfect, since the removable_storage_test will probably attempt to verify any scsi, sdio and usb device found on the system; I tested and I can "fool" the test by having a USB stick plugged in when I run the test; it will happily go and test that instead of the SD card. But since we have no way of telling cards from USB devices on some systems, I think adding the other device types is a reasonable workaround, versus just failing systems because this test is not considering the USB-presented cards.

Related branches

lp:~roadmr/checkbox/some-test-fixes

Merged into lp:checkbox at revision 1359

Jeff Lane : Approve on 2012-04-11

lp:checkbox

lp:~roadmr/ubuntu/precise/checkbox/0.13.7

Merged into lp:ubuntu/precise/checkbox

Mathieu Trudel-Lapierre: Approve on 2012-04-12

lp:ubuntu/precise/checkbox

Daniel Manrique (roadmr) on 2012-04-11

Changed in checkbox:
milestone:	none → 0.13.7
status:	New → In Progress
assignee:	nobody → Daniel Manrique (roadmr)
importance:	Undecided → High

Daniel Manrique (roadmr) on 2012-04-12

Changed in checkbox:
status:	In Progress → Fix Committed

Brendan Donegan (brendan-donegan) on 2012-07-18

Changed in checkbox:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.