Org unit setting types don't have groups assigned.

Bug #795252 reported by Joseph
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Invalid
Low
Unassigned

Bug Description

The table config.org_unit_setting_type has room for "groups" that the setting types can be assigned to, but these aren't currently used.

I've attached a patch that creates types for the setting types installed by the current seed-values script.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Joseph Lewis <joehms22 gmail com>

Tags: enhancement
Revision history for this message
Joseph (joehms22) wrote :
Changed in evergreen:
status: New → In Progress
importance: Undecided → Wishlist
importance: Wishlist → Low
Revision history for this message
Jason Stephenson (jstephenson) wrote :

This patch contains an upgrade script with a number that is already in use: 0550.

Think the patch needs work before being branchified. At least, I don't feel qualified at the moment to do the branchification.

Revision history for this message
Mike Rylander (mrylander) wrote :

A few specific issues with the patch, as it stands:

  * the oils_i18n_gettext() calls are using the wrong id value (prefixed with the table, instead of just being the pkey value for the row)
  * oils_i18n_gettext() is also using the wrong class (coust instead of csg)
  * it's almost certainly bit-rotten, we've been adding YAOUS' a good bit recently
  * the aforementioned prematurely assigned upgrade script number -- just replace with XXXX
  * ideally, the INSERTs into csg would also be placed in the seed data file, and the set of UPDATEs to coust would be integrated with the original INSERTS -- but I can live without that

All that said, I'd really like to see this picked back up. If it's dusted off and cleaned up, I will push it through to the finish line.

Changed in evergreen:
status: In Progress → Incomplete
Revision history for this message
Ben Shum (bshum) wrote :

Hmm, groups are assigned for most all of the library settings as of recent 2.4/master. So this bug was fixed at one point but never updated. Marking as invalid at this point given that this issue no longer exists.

Changed in evergreen:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.