eCryptfs

ecryptfs.mount_private should not try to update mtab if it is a symlink

Bug #789888 reported by Christophe Dumez
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
eCryptfs
Fix Released
Low
Unassigned

Bug Description

ecryptfs.mount_private currently attempts to update mtab even if it is a symbolic link. When mtab is symlinked to /proc/mounts, there is no point updating it and even worse, it will fail (see https://bugzilla.redhat.com/show_bug.cgi?id=706911).

Please find attached a patch that addresses the issue and that I tested successfully on my Machine (running Fedora 15). Without the patch, ecryptfs-mount-private fails with a "addmntent: Invalid argument" error.

Revision history for this message
Christophe Dumez (hydr0g3n) wrote :
Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

Any comment on this?

Please note that other programs such as mount.cifs have experienced the exact same issue and they have fixed it the same way [1].

[1] http://git.samba.org/rsync.git/?p=cifs-utils.git;a=commitdiff_plain;h=fba28cfe2f13dd8bdae3cec76178f42b001a40ca

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks, Christophe. This looks good to me.

Changed in ecryptfs:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

This was fixed a while ago in ecryptfs-utils-89, but not closed. Sorry! See revision 539.1.1.

Changed in ecryptfs:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.