Sometimes 'needs attention' windows refuse to acknowledge given attention

Bug #694866 reported by James Martin
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
DockbarX
Fix Released
Undecided
Unassigned

Bug Description

Most of the time, when a item on the dock starts blinking, focusing the window makes the blinking stop. This doesn't always happen. I haven't noticed exactly what makes this happen, but I see it most often with Pidgin conversations, although any window could potentially do this.

Edit: I forgot to mention this affects Dockbar X, not regular Dockbar. When I submitted this bug report, I wasn't aware there actually was a difference between the two.

James Martin (tr4shb4t)
description: updated
description: updated
Revision history for this message
arzali (wyfer) wrote :

I can reproduce this behavior with rhythmbox and other apps that are minimized to tray.
Dockbarx gives no errors and i need to refresh dbx to stop the blinking.

Revision history for this message
cdar (cdar07) wrote :

confirm, I have it too

Revision history for this message
Matias Särs (msevens) wrote :

I think I found the bug. Some really old code (pretty much unchanged since revision 1!) did something that didn't make any sense anymore.

Changed in dockbar:
status: New → Fix Committed
Revision history for this message
cdar (cdar07) wrote :

I think the bug is still present.

Revision history for this message
Matias Särs (msevens) wrote :

You used revision 335?

Revision history for this message
arzali (wyfer) wrote :

i've tested some older revisions and it seems that the bug begins with rev 310, so rev 309 works fine.
I hope this helps somehow

Revision history for this message
cdar (cdar07) wrote :

Yes. The bug was once before, I think.

Revision history for this message
Matias Särs (msevens) wrote :

Great bug hunting, arzali! I think I've got it. Test rev 337.

Revision history for this message
arzali (wyfer) wrote :

Good job! needs attention works now like it should be. Thanks for your hard work :)

Revision history for this message
arzali (wyfer) wrote :

hmm with rev 338+ i can reproduce it again with the steps above but it stops when i close the application.

Revision history for this message
Matias Särs (msevens) wrote :

With rev 342 as well?

Revision history for this message
arzali (wyfer) wrote :

yes and with 343 as well

Revision history for this message
Matias Särs (msevens) wrote :

Ah, found it. I wrote need_attention_changed instead of needs_attention_changed. Will commit a fix later. I'm in the middle of some coding now.

Changed in dockbar:
status: Fix Committed → In Progress
Matias Särs (msevens)
Changed in dockbar:
status: In Progress → Fix Committed
Matias Särs (msevens)
Changed in dockbar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.