Ubuntu
gcalctool package

gcalctool crashed with SIGSEGV in math_equation_insert()

Bug #651455 reported by ojab on 2010-09-29

This bug affects 2 people

	Status	Importance	Assigned to
GCalctool	Fix Released	Critical	gnome-bugs #629381
gcalctool (Ubuntu)	Fix Released	Medium	Unassigned
Maverick	Fix Released	Undecided	Unassigned

Bug Description

Impact: Calculator crashes when pasting and nothing in paste buffer
Resolution: Upstream code change (patch in comments below)
TEST CASE
1. Open calculator
2. Place the cursor in the test area
3. Ensure that the text area is empty
4. Press CTRL+C then press Ctrl+V
5. The calculator must not crash.

Risk: Low, simple a null pointer check

See original description

Tags:

Related branches

lp:~ubuntu-desktop/gcalctool/ubuntu

lp:ubuntu/maverick-proposed/gcalctool

Revision history for this message

ojab (ojab) wrote on 2010-09-29:

Dependencies.txt Edit (2.5 KiB, text/plain; charset="utf-8")
Disassembly.txt Edit (1.1 KiB, text/plain; charset="utf-8")
ProcMaps.txt Edit (35.6 KiB, text/plain; charset="utf-8")
ProcStatus.txt Edit (791 bytes, text/plain; charset="utf-8")
Registers.txt Edit (678 bytes, text/plain; charset="utf-8")
Stacktrace.txt Edit (5.2 KiB, text/plain; charset="utf-8")
ThreadStacktrace.txt Edit (5.9 KiB, text/plain; charset="utf-8")
XsessionErrors.txt Edit (7.9 KiB, text/plain; charset="utf-8")

Revision history for this message

Apport retracing service (apport) wrote on 2010-09-29:

StacktraceTop:
math_equation_insert (equation=0x1df5780, text=0x0) at math-equation.c:892
request_text_received_func (clipboard=0x209c6a0,
selection_received (widget=0x1fdd260,
g_closure_invoke ()
?? () from /usr/lib/libgobject-2.0.so.0

Revision history for this message

Apport retracing service (apport) wrote on 2010-09-29: Stacktrace.txt

Stacktrace.txt Edit (10.2 KiB, text/plain)

Revision history for this message

Apport retracing service (apport) wrote on 2010-09-29: ThreadStacktrace.txt

ThreadStacktrace.txt Edit (11.1 KiB, text/plain)

Changed in gcalctool (Ubuntu):
importance:	Undecided → Medium
tags:	removed: need-amd64-retrace

Pedro Villavicencio (pedro) on 2010-09-30

visibility:

private → public

Revision history for this message

Pedro Villavicencio (pedro) wrote on 2010-09-30:

this is known and fixed upstream as of today: https://bugzilla.gnome.org/show_bug.cgi?id=629381

Changed in gcalctool (Ubuntu):
status:	New → Fix Committed

Bug Watch Updater (bug-watch-updater) on 2010-09-30

Changed in gcalctool:
importance:	Unknown → Critical
status:	Unknown → Fix Released

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2010-10-14:

02_empty_paste.patch Edit (928 bytes, text/plain)

Fixes paste when buffer empty

description:

updated

Revision history for this message

Martin Pitt (pitti) wrote on 2010-10-14: Please test proposed package

Accepted gcalctool into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in gcalctool (Ubuntu Maverick):
status:	New → Fix Committed
tags:	added: verification-needed

Revision history for this message

Ara Pulido (ara) wrote on 2010-10-14:

Tested with gcalctool (5.32.0-0ubuntu2)
Pasting an empty buffer no longer makes the application crash.

Also, I run the mago regression tests on it, and they all passed.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Martin Pitt (pitti) wrote on 2010-10-15:

tags:	removed: verification-done
tags:	added: verification-needed

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2010-10-18:

#10

SRU verification for Maverick:
I have reproduced the problem with gcalctool 5.32.0-0ubuntu1 in maverick and have verified that the version of gcalctool 5.32.0-0ubuntu3 in -proposed fixes the issue.

Marking as verification-done

tags:	added: verification-done removed: verification-needed
description:	updated

Greg A (etulfetulf) on 2010-11-12

Changed in gcalctool (Ubuntu Maverick):
status:	Fix Committed → Fix Released
Changed in gcalctool (Ubuntu):
status:	Fix Committed → Fix Released