dockbarx doesn't save pinned applications

Bug #602960 reported by Tom Klaver
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DockbarX
Fix Released
Undecided
Unassigned

Bug Description

Pinned applications do not reappear when closing/starting dockbarx.

The following error shows up when i click 'Pin application':

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/dockbarx/dockbar.py", line 776, in on_pinned
    self.update_launchers_list()
  File "/usr/lib/python2.5/site-packages/dockbarx/dockbar.py", line 1080, in update_launchers_list
    self.globals.set_launchers_list(gconf_launchers)
  File "/usr/lib/python2.5/site-packages/dockbarx/common.py", line 404, in set_launchers_list
    launchers)
TypeError: value should be a string

DockBarX 0.39.4, gconf 2.28.1

Revision history for this message
Tom Klaver (tom-klaver) wrote :

Apparently identifier is unicode on my machine and therefore it's not saving a list of strings.

Quick fix: replaced
def update_launchers_list(self):
        # Saves launchers_list to gconf.
        launchers_list = self.groups.get_launchers_list()
        gconf_launchers = []
        for identifier, path in launchers_list:
            if identifier == None:
                identifier = ''
            gconf_launchers.append(identifier.encode('utf-8') + ';' + path)
            #old: gconf_launchers.append(identifier + ';' + path)
        self.globals.set_launchers_list(gconf_launchers)

in dockbar.py @ line 1079

Changed in dockbar:
status: New → Fix Committed
Revision history for this message
Matias Särs (msevens) wrote :

Thanks for the bug report and especially the suggested solution!

Fix committed means that the fix should have been committed to a bzr branch and that's not the case yet. I'll change the status.

Changed in dockbar:
status: Fix Committed → In Progress
Matias Särs (msevens)
Changed in dockbar:
status: In Progress → Fix Committed
Matias Särs (msevens)
Changed in dockbar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.