Please merge krename 4.0.4-2 (universe) from Debian unstable (main)

Is the 55639 line patch (debian/changes-4.0.4-2ubuntu1) intended?

Daniel,
They are needed, but, since they are missing desc, I am refreshing the debdiffs.

The .po changes should be documented in debian/changelog as a difference from Debian, but otherwise this looks fine.

Jonathan,

Ok, doing it in these debdiffs.

Hello bilal

Here is a review again!

1.Your changelog contains changes made in the debian package too whereas you should list only ubuntu specific changes in changelog

2. There is an absence of Maintainer field which generally has a @ubuntu.com address otherwise debuild fails on my system

bhavani@bhavani-desktop:~/development/krename/krename-4.0.4/debian$ debuild -S -sa -k4E5D6C5B
dpkg-buildpackage -rfakeroot -d -us -uc -S -sa
dpkg-buildpackage: set CFLAGS to default value: -g -O2
dpkg-buildpackage: set CPPFLAGS to default value:
dpkg-buildpackage: set LDFLAGS to default value: -Wl,-Bsymbolic-functions
dpkg-buildpackage: set FFLAGS to default value: -g -O2
dpkg-buildpackage: set CXXFLAGS to default value: -g -O2
dpkg-buildpackage: source package krename
dpkg-buildpackage: source version 4.0.4-2ubuntu1
dpkg-buildpackage: source changed by Bilal Akthar <email address hidden>
 fakeroot debian/rules clean
dh clean --with kde
   dh_testdir
   dh_auto_clean --buildsystem=kde
find: `./apps/konqueror': No such file or directory
find: `./kdesktop': No such file or directory
find: `./runtime/drkonqi': No such file or directory
find: `./workspace/khotkeys': No such file or directory
find: `./workspace/kwin': No such file or directory
find: `./runtime/kioslave/desktop': No such file or directory
cat: ./kolf/courses.list: No such file or directory
find: `./bovo/themes': No such file or directory
find: `./katomic/levels': No such file or directory
find: `./amor/data': No such file or directory
find: `./kdeprint': No such file or directory
find: `./kopete': No such file or directory
find: `./digikam': No such file or directory
   dh_clean
 dpkg-source -b krename-4.0.4
dpkg-source: error: Version number suggests Ubuntu changes, but Maintainer: does not have Ubuntu address
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-buildpackage: error: dpkg-source -b krename-4.0.4 gave error exit status 255
debuild: fatal error at line 1340:
dpkg-buildpackage -rfakeroot -d -us -uc -S -sa failed

(Hint: please use the update-maintainer script in ubuntu-dev-tools package to set the Maintainer field in debian/control)

3. The patch is generated automatically due to the changes outside debian directory and due to the use of 3.0 (quilt) format and it is unneeded as MoM says:

"Try and keep the diff small, this may involve manually tweaking po files and thelike."

And moreover the translations from upstream/debian are imported into rosetta after you have got the package uploaded. So the po file patch and the debian/series change is not required.

Regards

Done in these debdiffs.

yeah bilal

but you dont need to modify ubuntu > ubuntu diff as it serves for reviewers reference

secondly changelog formatting could be better as in

Merge from debian unstable. (LP: #601865) Remaining changes:
    - Export KUBUNTU_NO_DELETE_POT=1 in debian/rules so that the l10n stuff
    doesn't break the build

to

Merge from debian unstable. (LP: #601865) Remaining changes:
    - Export KUBUNTU_NO_DELETE_POT=1 in debian/rules so that the l10n stuff
      doesn't break the build

otherwise its fine!

Regards

Done in these debdiffs.