Changelog is not truncated for packages with 1: version number

Bug #45566 reported by Sitsofe Wheeler
12
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
Fix Released
Medium
Michael Vogt

Bug Description

Description of the problem:
Packages with 1: prefixing their version number have all of their changelog shown even though update-manager normally only shows the part of the changelog for versions of the package which are after the version currently installed.

Steps to reproduce:
1. On a yet to be updated dapper flight 5 do
dpkg -l capplets-data
see that the information returned is something like: capplets-data 2.14.1-0ubuntu7
2. sudo update-manager .
3. Make sure your updates list is up to date and click on capplets-data.
4. Ensure details are shown.

Expected results:
Changes tab to show entries from Version 1:2.14.1-0ubuntu8 .

Actual results:
Changes tab to showsentries from Version 1:1.2.2-1 .

Additional information:
This affects quite a few packages to e.g.
capplets-data
http://changelogs.ubuntu.com/changelogs/pool/main/c/control-center/control-center_2.14.1-0ubuntu10/changelog
gaim
http://changelogs.ubuntu.com/changelogs/pool/main/g/gaim/gaim_1.5.0+1.5.1cvs20051015-1ubuntu10/changelog
gnome-control-center
http://changelogs.ubuntu.com/changelogs/pool/main/c/control-center/control-center_2.14.1-0ubuntu10/changelog
ntpdate
http://changelogs.ubuntu.com/changelogs/pool/main/n/ntp/ntp_4.2.0a+stable-8.1ubuntu4/changelog
...

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

More packages with this problem:

capplets
gnome-control-center
gnome-mag
gthumb
gucharmap
iceauth
libgnome-mag2
libgtkmm-2.4-1c2a
libvte-common
xpmutils

However there are some packages which display a : in the version number but do seem to truncate their changelog:
bsdutils
http://changelogs.ubuntu.com/changelogs/pool/main/u/util-linux/util-linux_2.12r-4ubun
tu6/changelog
libgcc1
http://changelogs.ubuntu.com/changelogs/pool/main/g/gcc-4.0/gcc-4.0_4.0.3-1ubuntu5/c
hangelog

Revision history for this message
Adriaan Peeters (apeeters) wrote :

I commented in bug #40058 that I see this behaviour as well.

Changed in update-manager:
status: Unconfirmed → Confirmed
Revision history for this message
Adriaan Peeters (apeeters) wrote :

Hmm, another remark: are you sure the changes you see include changes for the version that is to be installed? For the example above: 1:2.14.1-0ubuntu8?

This 'long' changelog might be caused by the fact that an entry for the version to be installed in missing (see bug #40058).

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote : Fix for changelogs that don't use epoch when source package does

As the comments in the source hinted, the epoch stuff is a bit dicey. In this patch I strip the epoch off changelog versions and the source version number so it hopefully won't matter if they are there or not in all combinations.

I also compile the version matching regex outside the loop and don't do regex matching at all if we don't have a version number (which happens on things like new major numbered kernels)

Tested with:
capplets-data 2.14.1-0ubuntu7
gnome-control-center 2.14.1-0ubuntu7
gnome-mag 0.12.4-0ubuntu3
libgnome-mag2 0.12.4-0ubuntu3
libvte-common 0.12.1-0ubuntu1
gaim 1.5.0+1.5.1cvs20051015-1ubuntu9

acpi-support 0.84
app-install-data 0.1.32
firefox 1.5.dfsg+1.5.0.1-1ubuntu10
metacity 2.14.3-0ubuntu2
vim-common 6.4-006+2ubuntu4

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

Adriaan:

If you want to give some feed back I have a patched version of update-manager with my fixes over here: http://sucs.org/~sits/test/um.tar.gz

WARNING! Running random code off the net is dangerous. It is even more dangerous as root (which is required for testing my code). You do so at your own risk.

Revision history for this message
Adriaan Peeters (apeeters) wrote :

There are no epoch updates right now, so I cannot test it. I will do that when I get the chance :)

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

Adriaan:

xserver-xorg-input-mouse is an example

Revision history for this message
Adriaan Peeters (apeeters) wrote :

With the current version of update-manager (not your patched one) I get a changelog, but the entry for the to-be-installed version is missing.

Revision history for this message
Adriaan Peeters (apeeters) wrote :

What I expect: JUST the entry for the new version (and the changelog entries in between the current and the to-be-installed version).

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

I just see too many changelogs on the unpatched update-manager. The first entry is Version 1:1.0.3.1+cvs.20060109-0ubuntu1.1 (but perhaps I use different source URIs to you).

To test the patched one cd inside the patched update manager folder and sudo ./new-update-manager. Over here I see one changelog entry on that package with the patched one...

login, passwd and ppp should all be OK too...

Revision history for this message
Adriaan Peeters (apeeters) wrote :

With your version the changelog is empty :s

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

This bug is still here with Edgy... Can anyone review the attached patch?

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

nvidia-glx-legacy also seems to have this problem but mysteriously does not have a 1: in its version number...

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

This bug is still here with Feisty (Herd 5):

Version information:
update-manager 0.57.8

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks a lot for the detailed logs in this bugreport!

This should be fixed in my bzr tree now and will be part of the next upload (0.57.9)

Feedback is very welcome.

Cheer,s
 Michael

Changed in update-manager:
assignee: nobody → mvo
status: Confirmed → Fix Committed
Changed in update-manager:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.