"Also needs fixing here" should make the same checks used in +distrotask.

Bug #45015 reported by Diogo Matsubara
6
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Unassigned

Bug Description

Steps to reproduce (using sample data):
1. http://localhost:8086/distros/ubuntu/+source/mozilla-firefox/+bug/2
2. Click on "Also needs fixing here"
3. You'll end up with Ubuntu and mozilla-firefox (Ubuntu) bugtasks.
4. http://localhost:8086/distros/ubuntu/+source/mozilla-firefox/+bug/2/+editstatus
5. Clear the mozilla-firefox from the package field.
6. Click Save Changes
7. Crash like this: OOPS-135D119

Step 2 is the bug. You shouldn't be able to "Also needs fixing here" successfully in case a bugtask already exists for the context distro.

See also bug 246041, about abolishing the "Also Needs Fixing Here" button.

Tags: lp-bugs oops
Changed in malone:
status: Unconfirmed → Confirmed
Brad Bollenbach (bradb)
Changed in malone:
assignee: nobody → bradb
Revision history for this message
Diogo Matsubara (matsubara) wrote :

Quoting Brad:

"I think the real fix here is that the "Also Needs Fixing Here" button..
shouldn't be shown at all; there's no point showing the button if..
clicking it /will/ raise an error. :) But I'll probably need some..
input from mpt."

I totally agree with Brad. Matthew what do you think?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

How much sense does it make for a bug to be filed both on a distribution, and on one or more packages in that distribution? The early days of a vulnerability in commonly-statically-linked code might fall into this category, when not all of the buggy packages had been identified yet, so the bug needed attention from a general bugsquad. Is that something that ever happens? (Is zlib ever statically linked, for example?)

If they should be mutually exclusive, the first thing to do is fix Malone so that it crashes at step 2, not step 4. *Then* fix it so that the button isn't present in step 2. :-)

(This bug is sort of the opposite of bug 36286.)

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Perhaps another example would be renaming a distribution or distribution release (e.g. Ubuntu 6.04 -> 6.06). A distribution manager reports a bug on the distribution saying "All references to X must be changed to Y", and that bug report is used to track the changes in all packages using the old name.

Revision history for this message
Brad Bollenbach (bradb) wrote : Re: [Bug 45015] Re: "Also needs fixing here" should make the same checks used in +distrotask.

On Mon, 2006-22-05 at 04:39 +0000, Matthew Paul Thomas wrote:
> How much sense does it make for a bug to be filed both on a
> distribution, and on one or more packages in that distribution? The
> early days of a vulnerability in commonly-statically-linked code might
> fall into this category, when not all of the buggy packages had been
> identified yet, so the bug needed attention from a general bugsquad. Is
> that something that ever happens? (Is zlib ever statically linked, for
> example?)
>
> If they should be mutually exclusive, the first thing to do is fix
> Malone so that it crashes at step 2, not step 4. *Then* fix it so that
> the button isn't present in step 2. :-)

Based on the data I gathered from talking to Simon Law in Paris, it
makes sense to have only one task per distribution, distrorelease,
product, or productseries. Our current per-package assignee, milestone,
importance, etc. is too fine-grained 99.9% of the time.

Other things to consider:

* Mark wants the bug page to be contextless, which would mean this
button disappears completely.

* If we can show mark the value of context-as-a-magnifying-glass, and
decide to keep the bug page contextful, there are only two contexts
worth magnifying: distribution and product. Package-level context on the
bug page is confusingly fine-grained. This might make showing the button
an easier decision, showing it only if isn't marked as affecting the
current distro/product.

Brad

Changed in malone:
assignee: bradb → nobody
description: updated
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Fixed by fixing bug 246041.

Changed in malone:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.