System-config-printer-kde uses pygtk objects without import

Bug #436571 reported by Mikael Gerdin
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kdeadmin (Ubuntu)
Fix Released
High
Jonathan Riddell

Bug Description

Binary package hint: kdeadmin

system-config-printer-kde's options dialog does not work because it tries to use gtk objects and has not imported gtk.

Distributor ID: Ubuntu
Description: Ubuntu karmic (development branch)
Release: 9.10
Codename: karmic

system-config-printer-kde:
  Installed: 4:4.3.1-0ubuntu1
  Candidate: 4:4.3.1-0ubuntu1

$ kcmshell4 system-config-printer-kde
Traceback (most recent call last):
  File "/usr/share/kde4/apps/system-config-printer-kde/system-config-printer-kde.py", line 424, in on_tvMainList_cursor_changed
    self.fillPrinterTab(name)
  File "/usr/share/kde4/apps/system-config-printer-kde/system-config-printer-kde.py", line 1174, in fillPrinterTab
    editable=editable)
  File "/usr/share/kde4/apps/system-config-printer-kde/system-config-printer-kde.py", line 1655, in add_job_option
    self.option_changed)
  File "/usr/share/kde4/apps/system-config-printer-kde/options.py", line 66, in OptionWidget
    return OptionSelectOne(name, v, s, on_change)
  File "/usr/share/kde4/apps/system-config-printer-kde/options.py", line 315, in __init__
    self.selector = gtk.combo_box_new_text()
NameError: global name 'gtk' is not defined

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 25 14:17:36 2009
DistroRelease: Ubuntu 9.10
Package: system-config-printer-kde 4:4.3.1-0ubuntu1
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.35-generic
SourcePackage: kdeadmin
Uname: Linux 2.6.31-10-generic x86_64

Revision history for this message
Mikael Gerdin (mgerdin) wrote :
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

Should be changed to it's Qt equivalent. Likely whomever ported the function overlooked this.

Changed in kdeadmin (Ubuntu):
importance: Undecided → High
status: New → Triaged
assignee: nobody → Jonathan Riddell (jr)
Revision history for this message
Jonathan Riddell (jr) wrote :

I've ported this code now and uploaded in kdeadmin_4.3.2-0ubuntu2. Unfortunately I can't test the code myself in-situ because I don't have a printer which exposes options of these categories so testing is very welcome, open a new bug if there are any problems.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kdeadmin - 4:4.3.2-0ubuntu2

---------------
kdeadmin (4:4.3.2-0ubuntu2) karmic; urgency=low

  * Add kubuntu_02_system_config_printer_kde_i18n.py, closes LP: #424116
  * Add kubuntu_03_system_config_printer_kde_options.py, closes LP:
    #436571

 -- Jonathan Riddell <email address hidden> Tue, 13 Oct 2009 15:37:57 +0100

Changed in kdeadmin (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
wizik (dmitklg) wrote :

root@ubuntu:/usr/share/kde4/apps/system-config-printer-kde# kcmshell4 system-config-printer-kde
no talloc stackframe around, leaking memory
Caught non-fatal exception. Traceback:
File "/usr/share/kde4/apps/system-config-printer-kde/system-config-printer-kde.py", line 3313, in on_tvSMBBrowser_row_expanded
    while smbc_auth.perform_authentication () > 0:
File "/usr/share/kde4/apps/system-config-printer-kde/pysmb.py", line 98, in perform_authentication
    d = gtk.Dialog (_("Authentication"), self.parent,
NameError: global name 'gtk' is not defined
Continuing anyway..

Revision history for this message
wizik (dmitklg) wrote :

i have kubuntu 12 and this bug not fixed
root@ubuntu:/usr/share/kde4/apps/system-config-printer-kde# kcmshell4 system-config-printer-kde
no talloc stackframe around, leaking memory
Caught non-fatal exception. Traceback:
File "/usr/share/kde4/apps/system-config-printer-kde/system-config-printer-kde.py", line 3313, in on_tvSMBBrowser_row_expanded
    while smbc_auth.perform_authentication () > 0:
File "/usr/share/kde4/apps/system-config-printer-kde/pysmb.py", line 98, in perform_authentication
    d = gtk.Dialog (_("Authentication"), self.parent,
NameError: global name 'gtk' is not defined
Continuing anyway..

Revision history for this message
Jonathan Riddell (jr) wrote :

There's various bits of code needing ported to Qt, bugs are reported upstream already

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.