openswan ftbfs in karmic

My PPA Buildlog

http://launchpadlibrarian.net/32375998/buildlog_ubuntu-karmic-i386.openswan_1%3A2.6.22%2Bdfsg-1ubuntu1_FULLYBUILT.txt.gz

Regards

Hi,

nope, sorry, that's not good:

"/build/buildd/openswan-2.6.22+dfsg/programs/tncfg/tncfg.c:362: error: dereferencing pointer 'shc' does break strict-aliasing rules"

this should get fixed either with -fno-strict-aliasing or even better by an explicit cast to void * (and then to struct ipsecwhatever) in line 179.

Short explanation: In C, it's only legal to cast a pointer of one type to another, if it is a char * or a void *. gcc makes use of this knowledge in its alias anylsis (can one pointer refer to the same thing as another pointer), and hence has the possibility to assume that these two pointers are never the same. This can hence result in wrong optimizations.

Can you respin the debdiff please? (if there are other errors, it might of course be a good idea to disable Werror nonetheless).

Thanks,
     Stefan.

Okay stefan , thanks for pointing out mistake of my notion of overriding the errors here is the modified diff

Regards

Nice, thanks. Because I just saw it, I've added -1.1 from unstable before applying your patch. Hope that's ok with you. Uploading.

This bug was fixed in the package openswan - 1:2.6.22+dfsg-1.1ubuntu1

---------------
openswan (1:2.6.22+dfsg-1.1ubuntu1) karmic; urgency=low

  * Build with -fno-strict-aliasing against gcc 4.4 fix ftbfs LP: #436540

openswan (1:2.6.22+dfsg-1.1) unstable; urgency=low

  * Non-maintainer upload.
  * Fix LSB header in programs/setup/setup.in to fix init.d script
    (Closes: #537335).

 -- Bhavani Shankar <email address hidden> Sat, 26 Sep 2009 05:33:44 +0530

Thanks for quick sponsoring :)

Regards