QBzr

qlog: Column width miscalculated on Vista

Bug #430502 reported by Greg on 2009-09-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	QBzr	Fix Released	High	Alexander Belchenko	QBzr 0.23.1

Bug Description

The Log window does not appear to save the column width or they are miscalculated.
This can be a usability hit as the Date column must be manually resized each time.
It does appear to save the window size, though not the window position.

Please look at the attached screen shot to see this demonstrated.

System:
Windows 7 64
BZR Windows build v1.18.1
QBZR About says 'Version 0.13.1.final.0 (bzrlib 1.18.1)'

Related branches

lp:qbzr

Revision history for this message

Greg (gregspecialsource) wrote on 2009-09-16:

Log window column width not saved or miscalculated Edit (41.8 KiB, image/jpeg)

Revision history for this message

Alexander Belchenko (bialix) wrote on 2009-09-16:

Maybe we can save it.

Changed in qbzr:
importance:	Undecided → Wishlist
status:	New → Confirmed

Revision history for this message

Gary van der Merwe (garyvdm) wrote on 2009-09-24:

I think I have fixed the calculation of the width. Greg: if you can run from source, please will you test trunk, and verify if it is fixed.

Changed in qbzr:
assignee:	nobody → Gary van der Merwe (garyvdm)
status:	Confirmed → Fix Committed

Revision history for this message

Greg (gregspecialsource) wrote on 2009-09-24:

I grabbed (what I believe is the intended version) with 'bzr branch lp:qbzr' and rebooted.
qbzr is still listed as v0.15dev
I see no change in the column behavior. The date is still truncated and manual adjustments are not saved.

Revision history for this message

Greg (gregspecialsource) wrote on 2009-09-24:

Having said that, if the mouse drag behavior is accurate, the Date column is only 1 pixel short.

Gary van der Merwe (garyvdm) on 2009-10-22

Changed in qbzr:
importance:	Wishlist → Low
summary:	- Log window Column Width not saved or miscalculated + qlog: Column width miscalculated on Vista
Changed in qbzr:
importance:	Low → High

Alexander Belchenko (bialix) on 2009-11-19

Changed in qbzr:
status:	Fix Committed → Confirmed

Revision history for this message

Alexander Belchenko (bialix) wrote on 2009-12-08:

What's the status of this bug? Greg, can you test with latest qbzr trunk?

If we need just made it 1 pixel wider, let's just do it.

Revision history for this message

Greg (gregspecialsource) wrote on 2009-12-10:

Sorry, I have not updated qbzr recently. I'm also away at present and won't be able to provide any feedback until I return. If possible, please find another Windows user to confirm the status of this bug. Again, I'm sorry I can't assist for a while.

Revision history for this message

Greg (gregspecialsource) wrote on 2009-12-18:

qbzr v0.17.0 still exhibits this issue. Manually resizing the column by 1 pixel displays the full date and time without truncation.

Revision history for this message

André Bachmann (andrebachmann-dd) wrote on 2011-06-15:

I still can reproduce this problem with qbzr 0.21.0dev2 on Win7. The column of data is exactly one pixel too narrow. I need a little hint about where the column width is saved, because it isn't in qlog.py. Then I will try to fix this.

Revision history for this message

Alexander Belchenko (bialix) wrote on 2013-07-11:

#10

logwidget.py: LogList: __init__ has the code:

header.resizeSection(logmodel.COL_DATE,
fm.width("88-88-8888 88:88") + col_margin)

I believe that's the place where we calculate the width of date column.

Changed in qbzr:
assignee:	Gary van der Merwe (garyvdm) → Alexander Belchenko (bialix)
status:	Confirmed → In Progress
milestone:	none → 0.23.1