Text box doesn't go away after submitting bug description in Opera

Bug #414755 reported by Eleanor Berger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LAZR Javascript Library
Invalid
Medium
Unassigned
Launchpad itself
Fix Released
Medium
Deryck Hodge

Bug Description

When editing a bug's description inline in Opera, the text box remains visible even after a successful save. Instead, it should be hidden to reveal the static rendition of the text.

Tags: lp-bugs ui

Related branches

Deryck Hodge (deryck)
Changed in malone:
assignee: nobody → Deryck Hodge (deryck)
status: Triaged → In Progress
Changed in lazr-js:
assignee: nobody → Deryck Hodge (deryck)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Deryck Hodge (deryck) wrote :

For now, I'm going to have to disable the inline bug description editing for opera. Something is going wrong in the formatter function in Opera, so that YUI3 isn't creating or finding a proper set of child nodes when turning the HTML the API returns into DOM nodes.

Revision history for this message
Barry Warsaw (barry) wrote :

I have, but don't regularly use Opera. It's ashame this has to be disabled since it's a useful feature, but I think there's a possibility of data loss here (it seemed that way with some limited testing in Opera 9.64).

Revision history for this message
Deryck Hodge (deryck) wrote :

There's no need to fix this in the lazr-js branch. The LP branch is enough.

Changed in lazr-js:
assignee: Deryck Hodge (deryck) → nobody
status: In Progress → Invalid
Revision history for this message
Deryck Hodge (deryck) wrote :

Hi, Barry.

There's is a small chance of data loss if someone were to submit the empty textbox after the UI fails to update. The UI fail is after the initial description updates fine via the API.

The problem is in the formatter config option, around line 211 currently of lib/canonical/widgets/lazrjs.py. In these lines:

formatter: function(result, attribute) {
    var dl = Y.DOM.create(result)[1]
    var dl_nodes = dl.childNodes;

dl seems to be a fine enough DOM node when inspecting in Opera's debugger, but dl.childNodes is undefined.

I honestly didn't spend too much time trying to investigate given all the template work the bugs team has pending, but I hope this can be re-enabled reasonably soon. I'm sure there's a work around, but I didn't want an un-usable or dangerous experience for Opera users in the interim.

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r9209.

Changed in malone:
status: In Progress → Fix Committed
Deryck Hodge (deryck)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.