Convert the comment add templates to 3.0 UI

I'm continuing with the before and after photos, which seems to work well.

Hi Deryck,

Looking good.
One thing does pop-out at me: we seem to have 2 titles, the "Add a commen.." being an h1. I think it should be more like what we have on the bug index?

Hi, Martin.

The edit bug form was the same way and seemed odd to me. But I'm not doing anything except defining label and page_title in the view and this layout happens automatically, assuming I understand what I'm doing correctly. :-)

Perhaps the title should get the h1 and the label the h2. Or maybe the form label should be an h3. But I assume this would be in the base templates, not in what I'm doing, no?

Or maybe I should go back to defining my own heading slot and do an h1 of the form "Add a comment or attachment - Bug #XXXX: The bug title" which Gavin and I talked about when we first started into this?

Cheers,
deryck

Form does look wrong. it seems to have lots of headings. I am unsure of what I am seeing because the colours are different thatn overview. Actually. that may be it. We are appending to "Bug #1234 I see a bug". That is the default <h2> or the slot, and I expect that to be grey. The bread crumbs will be under it. the <h1> is "Add a comment"

slot: nothing (defaults to Bug #1234 I see a bug)
future breadcrumb jokosher > Bug #1234 I see a bug
<h1> Add a comment (from the form label)

So the comment field appears to be missing it's label.

I think I can express my expectations by using a working example: view https://launchpad.dev/firefox/trunk/+edit as sample person.

Thanks for this help, Curtis.

The thing that I'm confused about is that I *do* have a label on the form and yet the styling is not correct. And why is the default bug title heading not styled gray?

Can you look at the diff here and see if I've done something stupid?
http://bazaar.launchpad.net/~deryck/launchpad/comment-add-ui-updates-413611/revision/9114

Also, note that in the branch for bug 412971 I am even using generic-edit.pt, the only changes being to add label, page_title, and cancel_url per your suggestions on that bug, and the styling there is the same -- red headings, rather than a gray smaller heading followed by a green larger heading.

So in both cases maybe I've done the same stupid thing?

After much talking with Curtis yesterday, I learned a lot about heading-slot and h1,h2 placement in the new layout. But ultimately the problem of the headings being styled wrong came down to line 2039 of style.css. Thanks to Gavin for spotting the problem!

.tab-bugs headings have the color set to red. Removing this rule will make the headings in the new design look correct. Gavin and I assume this rule shouldn't be removed from style.css until later in the 3.0 conversion process, so existing pages are not ruined.

Here's the current state of the comment/attachment add form, after moving to use a LaunchpadFormView so that I could better follow Curtis' rules (for example, page_title matching form label). This is without the current style.css rule for red headings being removed.

And here's what the page will look like after the style rule is removed, which should be the final look for these types of pages.

(Sorry for the noise of comments and images on a minor page update, but I just want to document how I came to understand heading-slot, headings, etc. to be able to refer back to later if needed.)

Fixed in devel r9180.