FormOverlay should be able to load its form contents from a URL

Bug #412541 reported by Björn Tillenius
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LAZR Javascript Library
Fix Released
Undecided
Björn Tillenius
Launchpad itself
Invalid
Medium
Unassigned

Bug Description

We have quite a few places that load the form contents from an external URL. Currently to do this means copy&paste quite a lot of code. This functionality should be added directly to FormOverlay, so that we reduce code duplication.

Changed in lazr-js:
assignee: nobody → Björn Tillenius (bjornt)
status: New → In Progress
Revision history for this message
Björn Tillenius (bjornt) wrote :

Bugs, Code, and Registry have their own implementation for loading the form contents. They should all use the newly added loadFormContentsAndRender().

Revision history for this message
Curtis Hovey (sinzui) wrote :

The next time some need to hack on these for the registry, he should update the formoverlay. I anticipate this will be fixed by 3.0

Changed in launchpad-registry:
status: New → Triaged
importance: Undecided → Low
Changed in launchpad-code:
assignee: nobody → Björn Tillenius (bjornt)
milestone: none → 2.2.8
status: New → In Progress
Changed in malone:
assignee: nobody → Björn Tillenius (bjornt)
milestone: none → 2.2.8
status: New → In Progress
Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 412541] Re: FormOverlay should be able to load its form contents from a URL

On Thu, Aug 13, 2009 at 01:09:26PM -0000, Curtis Hovey wrote:
> The next time some need to hack on these for the registry, he should
> update the formoverlay. I anticipate this will be fixed by 3.0

I'm fixing it, since it's quite easy, and I don't want all overlay
callsites to do things differently. Better to try to be consistent early
on, while we still don't have many callsites.

Changed in launchpad-registry:
assignee: nobody → Björn Tillenius (bjornt)
milestone: none → 2.2.8
status: Triaged → In Progress
Revision history for this message
Björn Tillenius (bjornt) wrote :

Fixed in r119.

Changed in lazr-js:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 2.2.8 → 3.0
Deryck Hodge (deryck)
Changed in malone:
milestone: 2.2.8 → 3.0
Deryck Hodge (deryck)
Changed in malone:
milestone: 3.0 → 3.1.10
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 3.0 → 3.1.10
Tim Penhey (thumper)
Changed in launchpad-code:
milestone: 2.2.8 → 3.1.10
importance: Undecided → Medium
Changed in lazr-js:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
tags: added: infrastructure javascript post-3-ui-cleanup
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 3.1.10 → 3.0
status: In Progress → Fix Released
Deryck Hodge (deryck)
Changed in malone:
milestone: 3.1.10 → 3.1.11
Changed in launchpad-code:
milestone: 3.1.10 → 3.1.11
Deryck Hodge (deryck)
Changed in malone:
milestone: 3.1.11 → none
Changed in launchpad-code:
milestone: 3.1.11 → none
status: In Progress → Triaged
Changed in malone:
importance: Undecided → Medium
status: In Progress → Triaged
Changed in launchpad-code:
assignee: Björn Tillenius (bjornt) → nobody
Changed in malone:
assignee: Björn Tillenius (bjornt) → nobody
Huw Wilkins (huwshimi)
tags: added: ui
removed: post-3-ui-cleanup
Revision history for this message
Curtis Hovey (sinzui) wrote :

The primary fix is in Lp's tree. Any script that wants to use it can be fixed in a separate bug.

Changed in launchpad:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.