Launchpad itself

jslint warnings for bugtask-index.js

Bug #411379 reported by Björn Tillenius
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Björn Tillenius
Launchpad itself 2.2.8

Bug Description

jslint complaints about bugtask-index.js:

jslint: 1 file to lint.
jslint: Lint found in 'lib/canonical/launchpad/javascript/bugs/bugtask-index.js':
Line 1623 character 6: Unnecessary semicolon.
    };

Line 1683 character 40: Use '!==' to compare with ''.
        if (comment_input.get('value') != '') {

Tags: lp-bugs

Related branches

lp:~bjornt/launchpad/fix-jslint-warnings
Henning Eggers (community): Approve
Diff: None lines
Revision history for this message
Eleanor Berger (intellectronica) wrote :

While fixing this, it might be a good idea to also trim the value found in the comment box. If it's only whitespace, we should treat it like it is the empty string.

Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 411379] Re: jslint warnings for bugtask-index.js

On Mon, Aug 10, 2009 at 12:27:02PM -0000, Tom Berger wrote:
> While fixing this, it might be a good idea to also trim the value found
> in the comment box. If it's only whitespace, we should treat it like it
> is the empty string.

Too late :) Anyway, it's not important to trim it; it will be trimmed on
the server.

--
Björn Tillenius | https://launchpad.net/~bjornt

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r9081.

Changed in malone:
status: In Progress → Fix Committed
Björn Tillenius (bjornt)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.