Launchpad itself

Permissions review

Bug #400211 reported by Brad Crittenden
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Brad Crittenden
Launchpad itself 2.2.7

Bug Description

Recently a few new permissions have been added and need to be reviewed. Perhaps, instead of creating the novel launchpad.ProjectReview the standard launchpad.Moderate should have been used. The same *may* be true for launchpad.Commercial.

As part of the review the abilities granted to registry experts needs to be re-evaluated.

See original description
Tags: lp-registry
Revision history for this message
Brad Crittenden (bac) wrote :

It turns out we cannot replace launchpad.ProjectReview with launchpad.Moderate. The reason is there is an adapter for IFAQTarget and launchpad.Moderate. There is no way to have different adapters for IProduct (which implements IFAQTarget) and IFAQTarget.

So launchpad.ProjectReview is being kept. It needs to be changed from specifying "usedfor = Interface" to having specific adapters for each of the specific interfaces it needs: IProduct, IProductSet, IProject and IProjectSet.

summary: - Newly created permissions should be replaced with standard ones
+ Permissions review
description: updated
Diogo Matsubara (matsubara)
affects: launchpad → launchpad-registry
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in launchpad devel r8953.

Changed in launchpad-registry:
assignee: nobody → Brad Crittenden (bac)
importance: Low → High
milestone: none → 2.2.7
status: Triaged → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 400211 Fix released

Fixed released in Launchpad sinzui.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.