Unsetting duplicates via JavaScript is broken

Bug #396973 reported by Deryck Hodge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Deryck Hodge

Bug Description

A bug was introduced in rev 8782 in devel where the JavaScript for handling duplicates on a bug page no longer works to unset the bug as a duplicate. This is because bugtask-index.js was updated to correct an error reported by make lint, which in this case is wrong. The truthy form of `if foo != ''` is preferred here so that an empty string can be used to unset the duplicate.

There is a Windmill test at lib/lp/bugs/windmill/tests/test_bugs/test_mark_duplicate.py that is broken, too, that would have caught the error.

Tags: lp-bugs
Deryck Hodge (deryck)
Changed in malone:
assignee: nobody → Deryck Hodge (deryck)
importance: Undecided → High
milestone: none → 2.2.7
status: New → Triaged
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r8809.

Changed in malone:
status: Triaged → Fix Committed
Deryck Hodge (deryck)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.