Comment padding changes broke DSP:+index and BMP:+index

Bug #394524 reported by William Grant
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Tim Penhey

Bug Description

The comment header changes made in the past day or two broke DistributionSourcePackage:+index and BranchMergeProposal:+index. They both use boardComment and boardCommentDetail, so their padding is now very broken. The top line of each comment lacks padding, which (in the DSP case) each subsequent line has extra padding.

The padding is also now broken on commentless changes, as you'll see down there.

Tags: lp-bugs
William Grant (wgrant)
description: updated
Changed in malone:
importance: Undecided → High
milestone: none → 2.2.7
status: New → Triaged
Revision history for this message
Gavin Panella (allenap) wrote :

The padding is broken, but the overall appearance and usability is not harmed, imo. However, fixing it should be trivial (fingers crossed).

Tim Penhey (thumper)
Changed in malone:
assignee: nobody → Tim Penhey (thumper)
status: Triaged → In Progress
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r8913.

Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Tim Penhey (thumper) wrote :

Fixed in RF 8913.

Revision history for this message
Tim Penhey (thumper) wrote :

I just reread the comment and realised the distribution source package page had comment type divs too, but on checking, my fix fixes them too. Yay!

Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.