Launchpad itself

AJAX subscribe applet timesout with many subscribers pt. 2

Bug #393476 reported by Gavin Panella
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Graham Binns
Launchpad itself 3.1.11

Bug Description

The fix released for bug 386333 didn't work :( Try again.

Related branches

lp:~gmb/launchpad/subscriber-portlet-timeout-bug-393476
Abel Deuring (community): Approve (code)
Diff: 521 lines (+191/-95)
11 files modified
lib/canonical/launchpad/javascript/bugs/bugtask-index.js (+71/-4)
lib/lp/bugs/browser/bugsubscription.py (+9/-2)
lib/lp/bugs/browser/configure.zcml (+6/-0)
lib/lp/bugs/browser/tests/bug-portlet-subscribers-content.txt (+1/-1)
lib/lp/bugs/stories/bug-privacy/05-set-bug-private-as-admin.txt (+6/-3)
lib/lp/bugs/stories/bugs/bug-add-subscriber.txt (+4/-2)
lib/lp/bugs/stories/bugs/xx-bug-personal-subscriptions.txt (+35/-16)
lib/lp/bugs/templates/bug-portlet-dupe-subscribers-content.pt (+27/-0)
lib/lp/bugs/templates/bug-portlet-subscribers-content.pt (+8/-17)
lib/lp/bugs/templates/bug-portlet-subscribers.pt (+16/-46)
lib/lp/bugs/tests/bug.py (+8/-4)
Eleanor Berger (intellectronica)
Changed in malone:
milestone: 2.2.7 → 2.2.8
Revision history for this message
Deryck Hodge (deryck) wrote :

This works for me now. I don't see a commit, so marking invalid, but if someone fixed this, please update the bug.

Changed in malone:
status: Triaged → Invalid
Revision history for this message
Deryck Hodge (deryck) wrote :

Sorry, stupid me. Too many tabs open. Commented and changed wrong bug. Setting back as it was.

Changed in malone:
status: Invalid → Triaged
Deryck Hodge (deryck)
Changed in malone:
milestone: 2.2.8 → 3.1.10
Deryck Hodge (deryck)
Changed in malone:
milestone: 3.1.10 → 3.1.11
tags: added: bug-page timeout
Graham Binns (gmb)
Changed in malone:
assignee: nobody → Graham Binns (gmb)
status: Triaged → In Progress
Revision history for this message
Graham Binns (gmb) wrote :

This bug appears to be caused by the number of subscribers from dupes (1000+ in the case of the bug mentioned in bug 386333). I can't check properly, however, because interestingly enough that bug is now timing out completely. I'm working on finding out why.

In the case of the portlet timeout I think the best way to go about fixing it would be to load the subscribers-from-dupes bit of the portlet separately from the direct and also subscribed bits. This is simple enough to do (it's just a case of creating another portlet template to do the same job as what's already there but with different data) and should mean that if there's going to be a timeout it won't bork the portlet completely. It's not a perfect solution, but it's first step as we work to fix the actual problem, which is to do with the handling of large result sets on the server side.

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r9843 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/9843>

Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Graham Binns (gmb) wrote :

Whilst I *think* this bug solved at least one problem, fixing it uncovered another: bug 487015. The work to stop the bug page from timing out is now being tracked there.

Graham Binns (gmb)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.