Expensive method called twice when editing a team

Bug #391203 reported by Brad Crittenden
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Brad Crittenden

Bug Description

When editing a team the Person method 'visibiltyConsistencyWarning' is called twice, once by the form validator and once by the database validator. The method does a lot of small queries so is somewhat expensive.

The results from the first call should be cached.

Brad Crittenden (bac)
affects: launchpad → launchpad-registry
Changed in launchpad-registry:
assignee: nobody → Brad Crittenden (bac)
status: New → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

I believe this issue was discovered because of the timeouts on staging. I am marking this High because I think this jeopardises us doing good QA.

Changed in launchpad-registry:
importance: Undecided → High
milestone: none → 2.2.6
Brad Crittenden (bac)
Changed in launchpad-registry:
milestone: 2.2.6 → 2.2.7
Revision history for this message
Brad Crittenden (bac) wrote :

devel r8723

Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: story-private-teams
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 391203 Fix released

Fixed released in Launchpad sinzui.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.