unable to subscribe ~launchpad with new JS widget

Bug #388112 reported by Joey Stanford
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Edwin Grubbs

Bug Description

With the new add subscriber widget on Edge, I am no longer able to add ~launchpad without defeating the javascript by using middle click. The widget doesn't show any matches, even the exact ones, when a lot of results are found.

Ursula Junque (ursinha)
tags: added: js
description: updated
Revision history for this message
Martin Albisetti (beuno) wrote :

This is interesting. I think the way to solve this specific case is to always show exact matches first, and if there's too many matches, then just show the exact match.
Not sure what part of the machinery needs to be changed, but it would be nice to change it globally and not have to fix this bug on each person picker.
Deryck, I think this is your baby :)

affects: launchpad → malone
Changed in malone:
assignee: Martin Albisetti (beuno) → Deryck Hodge (deryck)
milestone: 2.2.6 → none
milestone: none → 2.2.6
Revision history for this message
Deryck Hodge (deryck) wrote :

Sure, I can take this one. :) I'm not sure I can get it this cycle, but I'll leave it targeted as such since I'm in an aggressive bug hunt mode for subscriber bugs.

I think the right fix is to sort by rank, rather than name, (so the likeliest matches top-post), and then show the first N results when the total is larger than N that can be displayed. We will need to investigate, too, if this change to the picker searching will be a problem for anywhere else this widget is used. My guess is not, since an empty result when dealing with a large result set would likely be a pain for most any use case.

Changed in malone:
status: New → Triaged
Revision history for this message
Deryck Hodge (deryck) wrote :

Assigning to lp-foundations, too, since it concerns the picker.

Changed in malone:
assignee: Deryck Hodge (deryck) → Edwin Grubbs (edwin-grubbs)
Changed in malone:
status: Triaged → In Progress
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

The picker is failing due to a timeout. OOPS-1266S267

Changed in malone:
importance: High → Critical
tags: added: javascript
removed: js
Revision history for this message
Graham Binns (gmb) wrote :

I'd question whether this is critical. Critical needs an incident report to be filed, amongst other things. Since this is in progress I'm going to move it back to high. It can be rolled out in a re-roll later this week.

Changed in malone:
importance: Critical → High
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in db r8199.

Changed in launchpad-foundations:
status: New → Fix Committed
Changed in malone:
status: In Progress → Fix Committed
Changed in malone:
status: Fix Committed → Fix Released
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.