Launchpad itself

Some unsubscribe buttons are on the left, others are on the right

Bug #383555 reported by Matthew Paul Thomas
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Unassigned
Launchpad itself 2.2.7

Bug Description

Even within the same bug report page, some unsubscribe buttons are on the left side of the subscribers box, while others are on the right. This looks ugly.

All unsubscribe buttons in the subscribers box should line up vertically.

See original description
Tags: lp-bugs
Revision history for this message
Matthew Paul Thomas (mpt) wrote :
description: updated
Revision history for this message
Deryck Hodge (deryck) wrote :

As of r8886 in devel, this is no longer quite true.

The remove icon is now to the right of the "Unsubscribe" that leads the portlet, but it is not aligned to the right as the others, so it still looks wonky. And given that the add icons align to the left for the subscribe links at the top of the portlet it feels weird to me to have the remove link change positions after the inline subscribe action.

Also, the JavaScript doesn't correctly handle the icon now since the change. But maybe that calls for another bug. :)

Changed in malone:
status: New → Incomplete
Revision history for this message
Martin Albisetti (beuno) wrote :

So, how about this for a design rule:

- When removing an object from the page, icon on the right
- When there's an action, on the left

mpt? sinzui?

Revision history for this message
Curtis Hovey (sinzui) wrote :

Um... isn't that the rule I landed yesterday and are seeing on edge now? I think I fixed this bug and I should get the karma for it.

    fmt:link knows the icon is on the left
    except for modification icons (edit, remove, trash) which are on the right
    fmt:link-icon and fmt:icon-link are deprecated. They defer to fmt:link.

Changed in malone:
assignee: nobody → Curtis Hovey (sinzui)
importance: Undecided → High
milestone: none → 2.2.7
status: Incomplete → Fix Committed
Revision history for this message
Deryck Hodge (deryck) wrote :

There's still one part of this that is not fixed. The icons need to line-up vertically, flush to the right, in the bug page subscribers portlet.

Also, I opened bug 400057 about the need for the subscribing js to be updated to accommodate the new design rule.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Reported bug 401658 about the alignment.

Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 383555 Fix released

Fixed released in Launchpad 2.2.7.

Changed in malone:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.