XMLRPCRunner should not log to error if there is no exception
Bug #383203 reported by
Barry Warsaw
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Barry Warsaw | ||
Bug Description
The OOPS reporting facility in log_exception() will print traceback text to logs/error even when there isn't an active traceback. Either this should ignore trackback printing when sys.exc_info() is (None, None, None) or we should add a log_info() function which doesn't print the traceback.
| tags: | added: mailing-lists |
| Changed in launchpad-registry: | |
| assignee: | nobody → Barry Warsaw (barry) |
| importance: | Undecided → Low |
| milestone: | none → 2.2.6 |
| status: | New → Triaged |
Revision history for this message
| Barry Warsaw (barry) wrote | #1 |
Revision history for this message
| Barry Warsaw (barry) wrote | #2 |
| Changed in launchpad-registry: | |
| status: | Triaged → In Progress |
Revision history for this message
| Barry Warsaw (barry) wrote | #3 |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 383203 Fix released | #4 |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Actually, there's only one call site where log_exception() is called outside of an except: handler. I think the simpler fix is to just turn this into a syslog() call, since it's not an exceptional condition and doesn't need an OOPS.