+mailing-list-subscribers page timing out with high statement count

Bug #381360 reported by Diogo Matsubara
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Guilherme Salgado

Bug Description

As seen in OOPS-1243B1623 the mailing-list-subscribers page is timing out with >2000 repeated queries

Revision history for this message
Curtis Hovey (sinzui) wrote :

Barry, do you think this can be addressed for the 2.2.5.1 reroll?

Changed in launchpad-registry:
assignee: nobody → Barry Warsaw (barry)
milestone: none → 2.2.5
Revision history for this message
Barry Warsaw (barry) wrote :

The problem is this: the page contains a potentially large number of people links, all displayed with person/fmt:link. This formatter hits the ValidPersonCache table to calculate the proper icon, so even though the getSubscribers() method can be instrumented to retrieve the appropriate ValidPersonCache entry, because the interface is defined to just return the person, this information is thrown away, resulting in a re-query for each person displayed.

The proper fix is to batch the page, as we do elsewhere. Alternatively, we could change the API of getSubscribers() to return the formatted person link HTML and use a structured TAL in the page template. The latter is probably still not good since we could potentially have many thousands of people as members of the mailing list and such a big page is not very useful (and could still take a long time to load).

Changed in launchpad-registry:
milestone: 2.2.5 → 2.2.6
Barry Warsaw (barry)
Changed in launchpad-registry:
assignee: Barry Warsaw (barry) → nobody
Barry Warsaw (barry)
Changed in launchpad-registry:
milestone: 2.2.6 → 2.2.7
Changed in launchpad-registry:
assignee: nobody → Guilherme Salgado (salgado)
status: Triaged → In Progress
Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 381360 Fix released

Fixed released in Launchpad sinzui.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.