Launchpad itself

class MilestoneVocabulary collects milestones unnecessarily inefficient

Bug #356520 reported by Abel Deuring
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Abel Deuring
Launchpad itself 2.2.5

Bug Description

MilestoneVocabulary.visible_milestones retrieves all milestones of a target and then removes those milestones that are not visible. Instead of using target.all_milestones, the method could simply acces MilestoneVocabulary.visible_milestones, which one contains active milestones.

Similary, a "targetless milestone vocabulary" should not be build by iterating over _all_ milestones but only over active milestones. See also OOPS-1191C894 and OOPS-1191G1276 .

Tags: lp-registry
Ursula Junque (ursinha)
affects: launchpad → launchpad-registry
Abel Deuring (adeuring)
Changed in launchpad-registry:
assignee: nobody → adeuring
status: New → In Progress
Revision history for this message
Abel Deuring (adeuring) wrote :

RF8198

Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 2.2.5
importance: Undecided → Low
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fix released in Launchpad 2.2.5.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.