account->person adaption is slow

Bug #356385 reported by Curtis Hovey
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Guilherme Salgado

Bug Description

allenap:
    person_from_account adapter seems to be having a punishing effect on
    performance

jamesh:
    The adapter should have been fairly cheap. [It was] changed it to do a
    query every time. A quick improvement would be to change the
    IAuthorization.checkAccountAuthenticated() to take both the account and
    person objects (person may be None) that would get rid of the need for
    account->person adaption in the security adapters entirely.

jamesh:
    Since the LaunchpadPrincipal has already looked up the person, feeding
    it directly to the IAuthorization adapter will probably still be faster.
    I'd expect that the majority of the calls are coming from the security
    adapter code

allenap:
    checkAccountAuthenticated in security.py which has solved my problem.
    But making person_from_team faster would be a more general fix.

Revision history for this message
Curtis Hovey (sinzui) wrote :

This will be a CP candidate.

Changed in launchpad-registry:
importance: Undecided → Critical
milestone: none → 2.2.4
status: New → Triaged
Curtis Hovey (sinzui)
description: updated
Curtis Hovey (sinzui)
Changed in launchpad-registry:
assignee: nobody → salgado
status: Triaged → In Progress
Revision history for this message
Guilherme Salgado (salgado) wrote :

r8167

Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

This was CPed April 10 2009.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
tags: added: story-performance-improvement
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.