Display interleaved diffs more prettily

Bug #350694 reported by William Grant
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Unassigned

Bug Description

Interleaved bug change diffs (descriptions, for example - see the change on https://bugs.edge.launchpad.net/malone/+bug/348406) are displayed in a boring and somewhat broken manner. Leading whitespace is stripped, so you end up with diffs looking rather unlike diffs (the first character of an unchanged line is aligned with the + or - of a changed line). Leading whitespace should be preserved, and changed lines should be highlighted somehow.

Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 350694] [NEW] Display interleaved diffs more prettily

On Sun, Mar 29, 2009 at 02:11:56AM -0000, William Grant wrote:
> Public bug reported:
>
> Interleaved bug change diffs (descriptions, for example - see the change
> on https://bugs.edge.launchpad.net/malone/+bug/348406) are displayed in
> a boring and somewhat broken manner. Leading whitespace is stripped, so
> you end up with diffs looking rather unlike diffs (the first character
> of an unchanged line is aligned with the + or - of a changed line).
> Leading whitespace should be preserved, and changed lines should be
> highlighted somehow.

We're going to start by removing the description diffs - they can get
potentially huge and should be collapsible, but that's a bugger to get
working at the moment without breaking the formatting.

The problem you describe with the unchanged lines is quite easy to
solve and can be done easily. The identification of changed lines will
be fixed in 2.2.4 as part of the "make it really awesome" work for
interleaved changes.

 status triaged
 milestone 2.2.4
 importance high

Changed in malone:
importance: Undecided → High
milestone: none → 2.2.4
status: New → Triaged
Revision history for this message
Graham Binns (gmb) wrote :

 tag story-activity-log-comment-interleaving

Would help if I tagged this properly too, I suppose...

Graham Binns (gmb)
Changed in malone:
assignee: nobody → gmb
Graham Binns (gmb)
Changed in malone:
status: Triaged → In Progress
Changed in malone:
importance: High → Medium
Revision history for this message
Graham Binns (gmb) wrote :

Marking this triaged again; we've not yet decided on the best way to do this.

Changed in malone:
status: In Progress → Triaged
Changed in malone:
milestone: 2.2.4 → none
Graham Binns (gmb)
Changed in malone:
assignee: Graham Binns (gmb) → nobody
Curtis Hovey (sinzui)
Changed in launchpad:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.