Launchpad itself

OOPSLoggingObserver should be a handler, not a logger

Bug #314959 reported by Jonathan Lange
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Invalid
Low
Unassigned

Bug Description

OOPSHandlingObserver bridges between the Twisted logging API and the Python logging API and adds OOPS logging features. Really, it should be split into a Python logging handler that generates OOPSes on particular events, and a Twisted/Python logging bridge that ensures Twisted errors are passed along properly.

Jonathan Lange (jml)
Changed in launchpad-bazaar:
assignee: nobody → mwhudson
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Steve Alexander (stevea) wrote :

I think Vincenzo has been working in this area for our OOPS handling code. Let's see if we can collaborate on this.

Revision history for this message
Jonathan Lange (jml) wrote : Re: [Bug 314959] Re: OOPSHandlingObserver should be a handler, not a logger

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, Jan 8, 2009 at 11:35 PM, Steve Alexander wrote:
> I think Vincenzo has been working in this area for our OOPS handling
> code. Let's see if we can collaborate on this.
>

Cool. I'll try to catch Vincenzo on IRC.

Are there already any plans to share the code?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: http://getfiregpg.org

iEYEARECAAYFAklmfVYACgkQX+0xPtMTonwDxwCglPgdxpgr5bYOmijF1EodunHo
35gAnje+IR6rV1k0vQIlkrIIqBHd26aF
=ORkk
-----END PGP SIGNATURE-----

Revision history for this message
Jonathan Lange (jml) wrote : Re: OOPSHandlingObserver should be a handler, not a logger

Looking at this now as a potential part of the fix for bug 274578.

Changed in launchpad-code:
assignee: Michael Hudson (mwhudson) → Jonathan Lange (jml)
status: Triaged → In Progress
Jonathan Lange (jml)
summary: - OOPSHandlingObserver should be a handler, not a logger
+ OOPSLoggingObserver should be a handler, not a logger
Jonathan Lange (jml)
Changed in launchpad-code:
status: In Progress → Fix Committed
Jonathan Lange (jml)
Changed in launchpad-code:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
tags: added: tech-debt
Revision history for this message
Stuart Bishop (stub) wrote :

This doesn't seem to be fixed - this bug is still referenced in lib/lp/services/twistedsupport/loggingsupport.py

I'm trying to land an OopsHandler for cronscripts, which is now causing twisted daemons to explode for some reason when I found the link to this bug.

Changed in launchpad-code:
status: Fix Released → Triaged
Jonathan Lange (jml)
visibility: private → public
Jonathan Lange (jml)
Changed in launchpad-code:
assignee: Jonathan Lange (jml) → nobody
Revision history for this message
Robert Collins (lifeless) wrote :

twisted log failures are rich and not well bridgable to python logging (in terms of capturing everything from the failure dict etc), so no, this shouldn't be a logger: it should be twisted specific and not bridge to python logging at all. I'm deleting the code entirely now, in favour of python-oops-twisted which includes a twisted specific non python logging implementation.

Changed in launchpad:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.