Ubuntu
gnome-shell-extension-tiling-assistant package

[MIR] gnome-shell-extension-tiling-assistant

Bug #2007710 reported by Sebastien Bacher
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-shell-extension-tiling-assistant (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[Availability]
The package gnome-shell-extension-tiling-assistant is already in Ubuntu universe.
The package gnome-shell-extension-tiling-assistant build for the architectures it is designed to work on.
It currently builds and works for architetcures: all
Link to package https://launchpad.net/ubuntu/+source/gnome-shell-extension-tiling-assistant

[Rationale]
- The package gnome-shell-extension-tiling-assistant is required in Ubuntu main to provide quarter tiling to our default desktop. The plan is to work upstream to get the feature integrated but that's going to take several cycle and we believe that using an extension is going to help providing feedback to guide the design decisions.

- The package gnome-shell-extension-tiling-assistant would ideally be in Ubuntu main for Feb 23th but it's not realistic at this point, we would still like to request a feature freeze exception and include it this cycle though.

[Security]
- No CVEs/security issues in this software in the past

- no `suid` or `sgid` binaries
- no executables in `/sbin` and `/usr/sbin`
- Package does not install services, timers or recurring jobs
- Packages does not open privileged ports (ports < 1024)
- Packages does not contain extensions to security-sensitive software

[Quality assurance - function/usage]
- The package works well right after install

[Quality assurance - maintenance]
- The package is maintained well in Debian/Ubuntu/Upstream, it has no report in Debian/Ubuntu and no major issues upstream
  - Ubuntu https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-tiling-assistant/+bug
  - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=gnome-shell-extension-tiling-assistant
  - Upstream's bug tracker, https://github.com/Leleat/Tiling-Assistant/issues
- The package does not deal with exotic hardware we cannot support

[Quality assurance - testing]
- The package does not run a test at build time since there is no testing framework for gnome-shell extensions

- The package does not run an autopkgtest because testing gnome-shell behaviour changes isn't something we can really do in the autopkgtest infrastructure

- There is a manual testplan for the package on https://wiki.ubuntu.com/DesktopTeam/TestPlans/GnomeShellExtensionTilingAssistant

In case the extension fails to load for whatever reason, the default mutter/gnome-shell standard tiling behavior will be used, so the users will be still able to use

[Quality assurance - packaging]
- debian/watch is present and works
- debian/control defines a correct Maintainer
- Recent build and lintian log: https://dpaste.com//9HSNBG8HR
- Lintian overrides are not present

- This package does not rely on obsolete or about to be demoted packages.
- This package has no python2 or GTK2 dependencies

- The package will be installed by default, but does not ask debconf questions

- Packaging and build is easy, link to d/rules https://salsa.debian.org/debian/gnome-shell-extension-tiling-assistant/-/blob/ubuntu/main/debian/rules

[UI standards]
- Application is end-user facing, Translation is present, via standard
  intltool/gettext or similar build and runtime internationalization
  system see https://github.com/Leleat/Tiling-Assistant/tree/main/translations

[Dependencies]
- No further depends or recommends dependencies that are not yet in main

[Standards compliance]
- This package correctly follows FHS and Debian Policy

[Maintenance/Owner]
- Owning Team will be desktop-packages
- Team is not yet, but will subscribe to the package before promotion

- This does not use static builds
- This does not use vendored code
- This package is not rust based
- The package has been built in the archive more recently than the last test rebuild

[Background information]
The Package description explains the package well
Upstream Name is tiling-assistant
Link to upstream project https://github.com/Leleat/Tiling-Assistant

See original description
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Manual testing steps added

description: updated
description: updated
Christian Ehrhardt  (paelzer)
Changed in gnome-shell-extension-tiling-assistant (Ubuntu):
assignee: nobody → Didier Roche-Tolomelli (didrocks)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Seems like the description was not correctly edited to remove the note that the testplan was going to be added later later and there was another section describing here which was also not updated to reflect that we moved the testcase to https://wiki.ubuntu.com/DesktopTeam/TestPlans/GnomeShellExtensionTilingAssistant which is the standard folder for our manual tests

description: updated
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Review for Package: gnome-shell-extension-tiling-assistant

[Summary]
MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.
This does not need a security review

Notes:
Required TODOs:
- the package has a recommends on gnome-shell-extension-prefs which is in universe. This should be dropped or promoted too. We can promote it easily as gnome-shell is in main, but IIRC, we wanted to not use that interface anymore and prefer gnome-extensions.

- The package should get a team bug subscriber before being promoted

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems:
- gnome-shell-extension-prefs is a recommends in universe. This should be dropped or promoted too. We can promote it easily as gnome-shell is in main, but IIRC, we wanted to not use that interface anymore and prefer gnome-extensions.

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries

OK:
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source.
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

[Common blockers]
OK:
- does not FTBFS currently
- does not hav a build or autopkgtests test suite. A manual test plan is provided
  as a mitigation solution.
- no new python2 dependency

[Packaging red flags]
OK:
- Ubuntu does carry a delta, but it is reasonable and maintenance under control
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
 - no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- part of the UI, no desktop file needed
- translation present

Changed in gnome-shell-extension-tiling-assistant (Ubuntu):
status: New → Incomplete
assignee: Didier Roche-Tolomelli (didrocks) → nobody
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Recommends -> Suggests of gnome-shell-extension-prefs handled in https://launchpad.net/ubuntu/+source/gnome-shell-extension-tiling-assistant/39-3ubuntu2

Didier Roche-Tolomelli (didrocks)
Changed in gnome-shell-extension-tiling-assistant (Ubuntu):
status: Incomplete → Fix Committed
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Override component to main
gnome-shell-extension-tiling-assistant 39-3ubuntu2 in mantic: universe/gnome -> main
gnome-shell-extension-ubuntu-tiling-assistant 39-3ubuntu2 in mantic amd64: universe/gnome/optional/100% -> main
gnome-shell-extension-ubuntu-tiling-assistant 39-3ubuntu2 in mantic arm64: universe/gnome/optional/100% -> main
gnome-shell-extension-ubuntu-tiling-assistant 39-3ubuntu2 in mantic armhf: universe/gnome/optional/100% -> main
gnome-shell-extension-ubuntu-tiling-assistant 39-3ubuntu2 in mantic i386: universe/gnome/optional/100% -> main
gnome-shell-extension-ubuntu-tiling-assistant 39-3ubuntu2 in mantic ppc64el: universe/gnome/optional/100% -> main
gnome-shell-extension-ubuntu-tiling-assistant 39-3ubuntu2 in mantic riscv64: universe/gnome/optional/100% -> main
gnome-shell-extension-ubuntu-tiling-assistant 39-3ubuntu2 in mantic s390x: universe/gnome/optional/100% -> main
Override [y|N]? y
8 publications overridden.

Changed in gnome-shell-extension-tiling-assistant (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.