Launchpad uses proprietary datepicker code

Bug #185388 reported by Matthew Paul Thomas
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Michael Nelson

Bug Description

Launchpad currently uses a proprietary "popcalxp" datepicker control. This should be replaced by something that we can customize, fix bugs in, and (eventually) open-source with the rest of Launchpad.

Ideally the new control should be based on <input type="date"> so that it is implemented natively in browsers that support it.

Changed in launchpad:
assignee: nobody → intellectronica
description: updated
Revision history for this message
Joey Stanford (joey) wrote :

I'll confirm this. Not sure why it's assigned to Tom though. Mark looked at all the JS datepicker code he could find and decided to buy a license for the one we have because it was the best out there and he didn't want to spend development resources creating a FOSS version.

Changed in launchpad:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Steve Alexander (stevea) wrote :

Actually, Joey, that's not quite right.

Of the first batch of tools Mark looked at, the JS datepicker we're currently using was the best.

We subsequently found a FOSS datepicker that is at least as good, and under a reasonable licence.

We should switch to using a better and FOSS library at some point in the future, as we will want to do further development on datepickers.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I assigned it to Tom because we chatted about the issue and he expressed willingness to implement a Free datepicker. If one is already available, that's even better.

Revision history for this message
Steve Alexander (stevea) wrote :

We should not develop our own date picker. That would place its ongoing maintenance on the Launchpad project.

Revision history for this message
Karl Fogel (kfogel) wrote :

Steve, do you remember the name of that FOSS datepicker that you liked? I just Googled, and there are a million of 'em out there now -- thus making it even more valuable to know the name of one that was already found to be decent :-).

Revision history for this message
Steve Alexander (stevea) wrote :

I don't recall. However, we'd want one that works with YUI, now that we've chosen to use that with Launchpad.

Revision history for this message
Karl Fogel (kfogel) wrote :

Put into 2.2.5 and unassign from Tom Berger, as per Francis's request.

For open-sourcing Launchpad, we need to pull the proprietary datepicker out. If we can, we should replace it with an open-source datepicker, but if not, then we'll ship with no datepicker (yuck).

Changed in launchpad-foundations:
assignee: Tom Berger (intellectronica) → nobody
importance: Low → High
milestone: none → 2.2.5
visibility: private → public
Changed in launchpad-foundations:
assignee: nobody → Michael Nelson (michael.nelson)
status: Triaged → In Progress
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Fixed in r8406.

I've added the yui2 calendar widget as the datepicker, and a slightly modified version for the date-time picker.

The extra page-weight for the yui2 dependencies is not included in launchpad.js, but as an extra 2 js and 1 css requests on the pages using the picker.

This is an intermediate solution until we have a yui3-based picker.

The behaviour of the new picker emulates the old one. It has one missing feature in that it does not yet limit the users choice if from_date and to_date have been specified (easy to update to support this as the calendar widget has support build-in and I've encoded the from/to dates on the template within a hidden span).

Changed in launchpad-foundations:
status: In Progress → Fix Committed
Karl Fogel (kfogel)
tags: added: lp-opensourcing
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.