Unable to rename rolling autosave

Does this happen on every auto save?

I had a similar issue when working with the editor. No console output, only a window pops up. The last sentence says: "Could not write xy.tmp to xy, the directory is not empty".

This happened when i was working on a scenario and had a texteditor open with my used files. I opened the widelands editor with the scenario map and made some modifications. Also made some modifications to a file opened in my text editor. I never had a problem when working like this (simultaniously editing the map and scenario files). The difference when the crash happens: I did not saved the open (edited!) scenario file before saving the map. So my guess is, at least in my case, that an unsaved change in a file leaves an open file handle to the directory, or to a file in the directory, which prevent saving anything there.

Could an open file handle also be the reason for this bug?

If so, what about file indexers? E.g. an auto save try's to save but an file indexer just indexes the file?

I think there was difference between savegames and new games. So, maybe the file handle doesn't get released when loading a game from a savegame? The problem would then occur when manually saving to the same file, or autosaving when the loaded game was a savegame.

See also bug 1785628 "crash during autosave"

I can reproduce this as follows:

1. Start an autosave game
2. Open the autosave game in 7zip
3. Wait for roll_save_files to come around -> crash

We have exception handling in the save game menu when that happens - I think we should just quietly fail here and skip to the next roll.

Fixed in build20-rc1