[FFe] libvirt v1.3.2 -- zfs support

Status changed to 'Confirmed' because the bug affects multiple users.

Hi Seth,

Debian actually doesn't yet have v1.3.2. I wonder whether we can just cherrypick the changes to src/storage/storage_backend_zfs.c

I think the more important cherrypick would be:
http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=82f17fbe68d3204932e72296fe07fd416aa8f9fc;hp=c94f6d4dff41b97f603738b6e749900eb83d19b2

Thanks

I also would tend to be conservative with pulling in the whole new version. While it seems to look not too bad (swapping out the orig tarball) the latest version is rather new and, as Serge already mentioned, right now would have no Debian import.

Just looking at the orig tarball replacement there were two of our patches that needed refresh to get rid of fuzz. The build failed through in some Xen testcases. Might be those are new and would just need the additional treatment I did for 1.3.1. Still there is potential for other new bugs and not much window left for testing.

So if we can get the feature (of ZFS) added by adding patches to 1.3.1 I would rather go that path. Serge got something prepared which I will go and have a review in a bit.

Ok, I guess patch#00 might be avoided by adjusting patch#05 but it looks to be rearrangement change only. So its a bit of a struggle to make up my mind between keeping closer to upstream changes and minimizing the additional delta.

For enabling support I guess we need to be selective. IIRC it is a 64bit arch only thing. So possibly

ifneq (,$(findstring $(DEB_HOST_ARCH), amd64, powerpc, ppc64el))
    WITH_ZFS = --with-storage-zfs
else
    WITH_ZFS = --without-storage-zfs
endif

The ppc64el part might need staging. In theory it should be build but I think I overheard(-read) some discussion yesterday about it being not done by accident.

Just to clarify, ZFS on Linux does build on i386, although the result may be of questionable use as of now.
So even though Ubuntu's zfsutils-linux gets built for amd64 only, the upstream project supports i386.

I would recommend to not be too selective here.

Quoting Stefan Bader (<email address hidden>):
...
> For enabling support I guess we need to be selective. IIRC it is a 64bit
> arch only thing. So possibly
>
> ifneq (,$(findstring $(DEB_HOST_ARCH), amd64, powerpc, ppc64el))
> WITH_ZFS = --with-storage-zfs
> else
> WITH_ZFS = --without-storage-zfs
> endif

Indeed, my i386 build without that failed :)
https://launchpad.net/~serge-hallyn/+archive/ubuntu/virt/+build/9327168

Status changed to 'Confirmed' because the bug affects multiple users.