Use a localized Accept-Language header
Bug #1224707 reported by
Chris Coulson
This bug affects 7 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Medium
|
Alexandre Abreu |
Bug Description
The Accept-Language header defaults to "en-us,en" if it hasn't been overridden by the embedder. But the default should be a string that's appropriate for the current locale
Related branches
lp:~abreu-alexandre/oxide/handle-local-specific-accept-language
- Chris Coulson: Needs Fixing
-
Diff: 144 lines (+105/-1)4 files modifiedshared/browser/oxide_browser_context_impl.cc (+2/-1)
shared/browser/oxide_language_utils_linux.cc (+71/-0)
shared/browser/oxide_language_utils_linux.h (+30/-0)
shared/shared.gyp (+2/-0)
lp:~abreu-alexandre/oxide/accept-language
- Chris Coulson: Approve
-
Diff: 1383 lines (+1101/-2)51 files modifiedCMakeLists.txt (+10/-0)
po/CMakeLists.txt (+26/-0)
po/am.po (+22/-0)
po/ar.po (+22/-0)
po/bg.po (+22/-0)
po/bn.po (+22/-0)
po/ca.po (+22/-0)
po/cs.po (+22/-0)
po/da.po (+22/-0)
po/de.po (+22/-0)
po/el.po (+22/-0)
po/es.po (+22/-0)
po/et.po (+22/-0)
po/fa.po (+22/-0)
po/fi.po (+22/-0)
po/fr.po (+22/-0)
po/gu.po (+22/-0)
po/he.po (+22/-0)
po/hi.po (+22/-0)
po/hr.po (+22/-0)
po/hu.po (+22/-0)
po/id.po (+22/-0)
po/it.po (+22/-0)
po/ja.po (+22/-0)
po/kn.po (+22/-0)
po/ko.po (+22/-0)
po/lt.po (+22/-0)
po/lv.po (+22/-0)
po/ml.po (+22/-0)
po/mr.po (+22/-0)
po/nb.po (+22/-0)
po/nl.po (+22/-0)
po/oxide.pot (+22/-0)
po/pl.po (+22/-0)
po/pt.po (+22/-0)
po/pt_BR.po (+22/-0)
po/ro.po (+22/-0)
po/ru.po (+22/-0)
po/sk.po (+22/-0)
po/sl.po (+22/-0)
po/sr.po (+22/-0)
po/sv.po (+22/-0)
po/sw.po (+22/-0)
po/ta.po (+22/-0)
po/te.po (+22/-0)
po/th.po (+22/-0)
po/tr.po (+22/-0)
po/uk.po (+22/-0)
po/vi.po (+22/-0)
po/xt.po (+22/-0)
shared/browser/oxide_browser_context.cc (+9/-2)
lp:~abreu-alexandre/oxide/gettext-domain-oxide-qt
- Chris Coulson: Approve
-
Diff: 59 lines (+8/-5)3 files modifiedCMakeLists.txt (+5/-3)
shared/browser/oxide_browser_context.cc (+1/-1)
shared/shared.gyp (+2/-1)
Changed in oxide: | |
importance: | Undecided → Medium |
status: | New → Triaged |
tags: | added: desktop webapp-container |
tags: |
added: webapps-hotlist removed: desktop webapp-container |
Changed in oxide: | |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Changed in oxide: | |
status: | Triaged → In Progress |
Changed in oxide: | |
milestone: | none → branch-1.1 |
Changed in oxide: | |
milestone: | branch-1.1 → branch-1.2 |
tags: | added: pat |
tags: | added: qa-daily-testing rmt14 touch |
tags: |
added: rtm14 removed: rmt14 |
Changed in oxide: | |
status: | In Progress → Fix Committed |
Changed in oxide: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I don't understand the purpose of this. That's precisely what the $LANGUAGE environment variable is for, can't Oxide just use that? (and fall back to $LANG if not set, as usual)