no-return-in-nonvoid-function

Bug #1050399 reported by Adam Mizerski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cairo-Dock Core
Fix Released
High
Unassigned

Bug Description

1) in file cairo-dock-desklet-factory.c "gboolean cairo_dock_detach_icon_from_desklet (Icon *icon, CairoDesklet *pDesklet)" needs "return TRUE;" at the end.
2) in file cairo-dock-dock-factory.c "static gboolean _on_dock_destroyed (GtkWidget *menu, CairoContainer *pContainer)" needs "return CAIRO_DOCK_LET_PASS_NOTIFICATION;" (I'm not sure. someone must check it) at the end.
3) in file cairo-dock-file-manager.c "static gpointer _cairo_dock_fm_launch_uri_threaded (gchar *cURI)" needs "return NULL;" at the end.
4) in file cairo-dock-module-manager.c "static gboolean _write_modules (gpointer data)" return value should be changed to void.

Revision history for this message
Adam Mizerski (m-adam-i) wrote :
Revision history for this message
Adam Mizerski (m-adam-i) wrote :

update: in point 2 there should be rather "return CAIRO_DOCK_INTERCEPT_NOTIFICATION;", but anyway someone should check it.

Revision history for this message
Fabounet (fabounet03) wrote :

Hi,
you're absolutely right, thank you for this patch ! :-)

Changed in cairo-dock-core:
importance: Undecided → High
status: New → Fix Committed
Changed in cairo-dock-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.