Awn

Comment 6 for bug 156697

Revision history for this message
moonbeam (rcryderman) wrote :

I've seem to have tracked down the reflection bug. It was unrelated to this patch per se. Though it is in the same file.

I'm not exactly confident of the root cause but I actually suspect that it is a gdk bug. It seems that gdk_pixbuf_flip sometimes fails to generate a valid pixbuf even if it believes the pixbuf given as an argument is a valid pixbuf. Basically what I'm doing is checking if ->reflect is a valid pixbuf and if it isn't I'm using the orig_icon to create a reflection instead.

Not perfectly happy with this yet. But my current patch seems to be giving reflections without fail... no more disappearing reflection!

Patch to follow in a few minutes. It will contain, the previous fixes, the remove of the temp==false logic and the reflection fixes.