Comment 5 for bug 156697

A few comments after having used this patch myself for several days. Along with several others.

1) The graphical corruption issues I saw with rendered icons under load have basically disappeared. As has console spam associated with changing icons while under load (less common than the simple icon graphical corruption). I have not been able to trigger this with stable testing even when I try recently while I more or less can do so with ease on trunk. A note: I suspect the higher spec a machine is the harder it is to trigger the condition.

2) From a subjective perspective I feel that applets that make use of icon change functions have greater stability. The tendency to just silently crash seems greatly reduced. I haven't experienced an overall decrease in awn crashing just because the trunk hasn't been prone to simple crashes for me for a long time. I attribute this to the fact that I do not use launchers - the code that deals with that seems to have been in need of some love.

I don't see any issue in the patched code yet. But I'm going to go ahead and clean out the priv->temp code today to make the source cleaner. Maybe an issue will pop out at me then.